Added changes to have multipart sync & async call using actual server #405
+243
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jclingan @Emily-Jiang: @jamezp is going to check this change out on RESTEasy. We have already confirmed it on Open Liberty. Once James has confirmed we will need one of you to merge as none of us have authority. But before you do that, perhaps it would be good for one of you to create a |
jamezp
reviewed
Oct 8, 2025
| private AsyncFileManagerClient createClient() { | ||
| try { | ||
| return RestClientBuilder.newBuilder() | ||
| .baseUri(createCombinedUri(uri, "entitypart")) |
There was a problem hiding this comment.
FWIW this could just be:
.baseUri(UriBuilder.fromUri(uri).path("entitypart").build())Then the createCombineUri could be removed. Not critical though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated EntityPartTest to perform a full server‑side process and remove the filter.
Added a new test, called AsyncEntityPartTest, to exercise the asynchronous call path with a full server process.
Resolves #403