fix: Updated the networking module

[Prekshith-Microsoft]

Purpose

This pull request refactors the networking components of the infrastructure deployment and improves post-deployment documentation. The main changes include replacing the legacy network.bicep module with a new approach that defines networking resources directly in main.bicep, updating resource references throughout the codebase, and adding a new post-deployment guide.

Networking module refactor and resource integration:

• Removed the legacy infra/modules/network.bicep file and replaced its functionality by defining the virtual network, subnets, Bastion host, and Jumpbox VM directly in infra/main.bicep. This change simplifies the networking architecture and makes resource management more transparent. [1] [2]
• Updated all references to networking outputs throughout infra/main.bicep to use the new virtualNetwork module outputs instead of the old network module outputs. This affects private endpoint subnet assignments, web app subnet configuration, and DNS zone linking. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Documentation improvements:

• Added a new docs/AVMPostDeploymentGuide.md file, providing clear instructions for post-deployment steps, including sample data import, authentication setup, and resource cleanup.

Tagging and output updates:

• Added a DeploymentName tag to resource group tags for better tracking of deployments.
• Removed the AZURE_CLIENT_ID output from infra/main.bicep, streamlining output variables.

These changes make the networking setup more modular and maintainable, improve documentation for users, and ensure resource references are consistent throughout the deployment.

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

This pull request refactors the networking setup in the infrastructure codebase to simplify resource management and improve clarity. The main change is the replacement of the previous network module with a new virtualNetwork module, which now handles the creation and management of the virtual network, subnets, network security groups, Bastion host, and Jumpbox VM directly. As a result, references throughout the codebase have been updated to use outputs from the new virtualNetwork module instead of the old network module. Additionally, the now-obsolete modules/network.bicep and modules/network/bastionHost.bicep files have been removed.

Networking module refactor and resource management:

• Replaced the network module with a new virtualNetwork module in infra/main.bicep, consolidating VNet, NSG, subnet, Bastion host, and Jumpbox VM creation into a single module for improved clarity and maintainability.
• Removed the obsolete modules/network.bicep and modules/network/bastionHost.bicep files, as their responsibilities have been migrated to the new virtualNetwork module. [1] [2]

Resource reference updates:

• Updated all references to subnet and VNet resource IDs in dependent modules (e.g., Private DNS Zones, Key Vault, AI Services, Cosmos DB, Storage Account, SQL Server, Web Sites, Search Service) to use outputs from virtualNetwork instead of network, ensuring correct resource linkage after the module change. [1] [2] [3] [4] [5] [6] [7] [8] [9]

This refactor streamlines the networking infrastructure, reduces duplication, and makes future maintenance easier by centralizing network-related resource definitions and outputs.