refactor(odsp-client): Move ODSP Container Services into a class #25646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors ODSP Container Services from a functional approach to a class-based implementation to prepare for future asynchronous functionality and class/extension syntax requirements.
Key changes:
- Creates a new
OdspContainerServicesclass that implements theIOdspContainerServicesinterface - Replaces inline object creation with class instantiation in the ODSP client
- Updates type references to use the interface instead of the concrete type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/service-clients/odsp-client/src/odspContainerServices.ts | New file containing the OdspContainerServices class implementation |
| packages/service-clients/odsp-client/src/odspClient.ts | Updated to use the new class instead of inline object creation and updated imports/type references |
|
It looks good to me. |
jatgarg
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves ODSP Container Services into a
classimplementation to prepare for changes coming out of #25597.Reviewer Guidance
This PR seems pointless on the surface, but it will make life significantly easier when asynchronously adding various functionality to the ODSP Container Services, some of which use class/extension syntax.