Skip to content

Conversation

kgodara912
Copy link
Contributor

@kgodara912 kgodara912 commented Aug 14, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Addresses CVE-2024-7409 for qemu

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/3.0 PRs Destined for Azure Linux 3.0 labels Aug 14, 2025
@kgodara912 kgodara912 marked this pull request as ready for review August 18, 2025 11:07
@kgodara912 kgodara912 requested a review from a team as a code owner August 18, 2025 11:07
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch Analysis (the patch applies cleanly w.r.t to upstream)
Failing Test : libguestfs is known failure.

  • Buddy Build 
  • patch applied during the build (check rpm.log)
  • patch include an upstream reference
  • PR has security tag

@Kanishk-Bansal Kanishk-Bansal added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Aug 22, 2025
@kgodara912 kgodara912 marked this pull request as draft August 25, 2025 13:30
@kgodara912 kgodara912 force-pushed the kgodara/fasttrack/3.0/qemu/CVE-2024-7409 branch from 0604a94 to 485fc6e Compare August 25, 2025 13:43
@kgodara912
Copy link
Contributor Author

Buddy build, adding one more follow-up change for the CVE as pointed by @Kanishk-Bansal .

@kgodara912 kgodara912 force-pushed the kgodara/fasttrack/3.0/qemu/CVE-2024-7409 branch from 485fc6e to 9a07619 Compare August 25, 2025 13:46
@kgodara912 kgodara912 marked this pull request as ready for review August 25, 2025 17:22
Copy link
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgodara912: thank you for updating the patches, looks good. One request for the future: could I ask you to not rebase where you squish new commits with old ones? GitHub is only allowing to compare commits, so if you squish an update with an older commit, it's impossible to view the delta and makes reviewing harder. We end up squishing the whole PR anyway as we merge it, so even if a PR has many single commits, it doesn't create a mess in the base branch.

@PawelWMS
Copy link
Contributor

PR looks good, waiting for the monthly release to be done before merging.

@kgodara912
Copy link
Contributor Author

kgodara912 commented Aug 28, 2025

I haven't done extensive manual testing, but I have done minimal verification to avoid basic regression. I have verified booting of Azure Linux iso with qemu-system-x86_64 and it could boot the iso and installs the Azure Linux on qcow2 disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/3.0 PRs Destined for Azure Linux 3.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants