-
Notifications
You must be signed in to change notification settings - Fork 592
Patch qemu for CVE-2024-7409 [HIGH] #14519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fasttrack/3.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch Analysis (the patch applies cleanly w.r.t to upstream)
Failing Test : libguestfs is known failure.
- Buddy Build
- patch applied during the build (check
rpm.log
) - patch include an upstream reference
- PR has security tag
0604a94
to
485fc6e
Compare
Buddy build, adding one more follow-up change for the CVE as pointed by @Kanishk-Bansal . |
485fc6e
to
9a07619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgodara912: thank you for updating the patches, looks good. One request for the future: could I ask you to not rebase where you squish new commits with old ones? GitHub is only allowing to compare commits, so if you squish an update with an older commit, it's impossible to view the delta and makes reviewing harder. We end up squishing the whole PR anyway as we merge it, so even if a PR has many single commits, it doesn't create a mess in the base branch.
PR looks good, waiting for the monthly release to be done before merging. |
I haven't done extensive manual testing, but I have done minimal verification to avoid basic regression. I have verified booting of Azure Linux |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Addresses CVE-2024-7409 for qemu
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology