Skip to content

[2.0] Passed Azure config to toolkit build env. #14527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Aug 15, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We're adding support for anonymous Azure blob stores in #14494. This change is to help with that work by making the Azure configuration (including login info) exposed during build-time. Since the toolkit requires to be run as root, the user's Azure config is not visible by default, because it's saved under $HOME/.azure and since we're running as root, the home directory is different from the running user's home directory.

This is a 2.0 backport of #14526. Updates to our build infrastructure will require this change for 2.0 builds as well.

Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Local tests.
  • Budd builds where the toolkit attempts to upload files to a test Azure Storage Account using the new authentication method:

@PawelWMS PawelWMS requested a review from a team as a code owner August 15, 2025 21:42
@microsoft-github-policy-service microsoft-github-policy-service bot added Tools main PR Destined for main labels Aug 15, 2025
@PawelWMS PawelWMS force-pushed the pawelwi/2.0_passing_az_config branch from c6a99ad to 40eb29e Compare August 15, 2025 22:00
@christopherco christopherco merged commit e0fca46 into main Aug 23, 2025
17 checks passed
@christopherco christopherco deleted the pawelwi/2.0_passing_az_config branch August 23, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants