ClangTidy issue in lib/system/Route.hpp #1297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIROSN
force-pushed
the
user/hirosn/clangtidyissue
branch
2 times, most recently
from
001f441 to
7ff3234
Compare
HIROSN
force-pushed
the
user/hirosn/clangtidyissue
branch
from
8b0db87 to
2599dc7
Compare
HIROSN
changed the title
ThomsonTan
reviewed
Aug 30, 2024
| { | ||
| for (IRoutePassThrough<TArgs...>* target : m_passthroughs) { | ||
| if (!(*target)(std::forward<TRealArgs>(args) ...)) { | ||
| if (!(*target)(args ...)) { |
There was a problem hiding this comment.
Will args be coped for each call?
ThomsonTan
reviewed
Aug 30, 2024
| RouteSink<RouteTests, int> sink1{this, &RouteTests::handleSink1}; | ||
| RoutePassThrough<RouteTests, int> passThrough1a{this, &RouteTests::handlePassThrough1a}; | ||
| RoutePassThrough<RouteTests, int> passThrough1b{this, &RouteTests::handlePassThrough1b}; | ||
| RouteSink<RouteTests, int, bool&, NonCopyableThing const&, Canary> sink4{this, &RouteTests::handleSink4}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RouteSource::operator(), r-value's in 'args' are used in a later loop iteration after they were forwarded/moved to a target in the first loop iteration. Proposed fix is to remove usage of std::forward and pass 'args' only as l-value's to targets.