Set default to raise ItemInvoked after selection change #10814
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the default value of `m_shouldRaiseItemInvokedAfterSelection` in `NavigationView.h` from `false` to `true`. This ensures that the "item invoked" event is raised by default after a selection change, aligning with the intended behavior of the `NavigationView` component. This change may affect how selection changes are handled and how the component interacts with other parts of the application.
microsoft-github-policy-service
bot
added
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default value of
m_shouldRaiseItemInvokedAfterSelectioninNavigationView.hfromfalsetotrue. This ensures that the "item invoked" event is raised by default after a selection change, aligning with the intended behavior of theNavigationViewcomponent. This change may affect how selection changes are handled and how the component interacts with other parts of the application.Fixes
Fix an issue that
NavigationView.ItemInvokeevent is not invoked for the first item navigation.PR Type
Please check the type of change your PR introduces:
Description
Current Behavior
The first item navigation will not invoke
ItemInvokeeventNew Behavior
The first item navigation will invoke
ItemInvokeeventMotivation and Context
How Has This Been Tested?
Screenshots (if appropriate):