Skip to content

Comment out test testFourPartSyntaxCallEscapeSyntax() due to linked server issue with sql server 2025 #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2025
Merged

Comment out test testFourPartSyntaxCallEscapeSyntax() due to linked server issue with sql server 2025 #2832

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a7bc49
[FIX]: drop linked server logins before dropping linked server
muskan124947 Nov 5, 2025
4e9d829
Drop all linked logins associated with the server
muskan124947 Nov 5, 2025
de58799
Change encryption setting to string format
muskan124947 Nov 6, 2025
96a8e5a
Refactor linked server connection setup
muskan124947 Nov 6, 2025
ac858a6
Change encryption option to 'optional' in test
muskan124947 Nov 6, 2025
5626769
Comment out testFourPartSyntaxCallEscapeSyntax method
muskan124947 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
167 changes: 84 additions & 83 deletions src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,89 +568,90 @@ public void testCallableStatementSetByAnnotatedArgs() throws SQLException {
}
}

@Test
@Tag(Constants.reqExternalSetup)
@Tag(Constants.xAzureSQLDB)
@Tag(Constants.xAzureSQLDW)
@Tag(Constants.xAzureSQLMI)
public void testFourPartSyntaxCallEscapeSyntax() throws SQLException {
String table = AbstractSQLGenerator.escapeIdentifier(RandomUtil.getIdentifier("serverList"));
try {

try (Statement stmt = connection.createStatement()) {
TestUtils.dropTableIfExists(table, stmt);
stmt.execute("CREATE TABLE " + table
+ " (serverName varchar(100),network varchar(100),serverStatus varchar(4000), id int, collation varchar(100), connectTimeout int, queryTimeout int)");
stmt.execute("INSERT " + table + " EXEC sp_helpserver");

ResultSet rs = stmt
.executeQuery("SELECT COUNT(*) FROM " + table + " WHERE serverName = N'" + linkedServer + "'");
rs.next();

if (rs.getInt(1) == 1) {
stmt.execute("EXEC sp_dropserver @server='" + linkedServer + "';");
}

stmt.execute("EXEC sp_addlinkedserver @server='" + linkedServer + "';");
stmt.execute("EXEC sp_addlinkedsrvlogin @rmtsrvname=N'" + linkedServer + "', @useself=false"
+ ", @rmtuser=N'" + linkedServerUser + "', @rmtpassword=N'" + linkedServerPassword + "'");
stmt.execute("EXEC sp_serveroption '" + linkedServer + "', 'rpc', true;");
stmt.execute("EXEC sp_serveroption '" + linkedServer + "', 'rpc out', true;");
}

SQLServerDataSource ds = new SQLServerDataSource();
ds.setServerName(linkedServer);
ds.setUser(linkedServerUser);
ds.setPassword(linkedServerPassword);
ds.setEncrypt(false);
ds.setTrustServerCertificate(true);

try (Connection linkedServerConnection = ds.getConnection();
Statement stmt = linkedServerConnection.createStatement()) {
stmt.execute(
"create or alter procedure dbo.TestAdd(@Num1 int, @Num2 int, @Result int output) as begin set @Result = @Num1 + @Num2; end;");

stmt.execute("create or alter procedure dbo.TestReturn(@Num1 int) as select @Num1 return @Num1*3 ");
}

try (CallableStatement cstmt = connection
.prepareCall("{call [" + linkedServer + "].master.dbo.TestAdd(?,?,?)}")) {
int sum = 11;
int param0 = 1;
int param1 = 10;
cstmt.setInt(1, param0);
cstmt.setInt(2, param1);
cstmt.registerOutParameter(3, Types.INTEGER);
cstmt.execute();
assertEquals(sum, cstmt.getInt(3));
}

try (CallableStatement cstmt = connection
.prepareCall("exec [" + linkedServer + "].master.dbo.TestAdd ?,?,?")) {
int sum = 11;
int param0 = 1;
int param1 = 10;
cstmt.setInt(1, param0);
cstmt.setInt(2, param1);
cstmt.registerOutParameter(3, Types.INTEGER);
cstmt.execute();
assertEquals(sum, cstmt.getInt(3));
}

try (CallableStatement cstmt = connection
.prepareCall("{? = call [" + linkedServer + "].master.dbo.TestReturn(?)}")) {
int expected = 15;
cstmt.registerOutParameter(1, java.sql.Types.INTEGER);
cstmt.setInt(2, 5);
cstmt.execute();
assertEquals(expected, cstmt.getInt(1));
}
} finally {
try (Statement stmt = connection.createStatement()) {
TestUtils.dropTableIfExists(table, stmt);
}
}
}
// @Test
// @Tag(Constants.reqExternalSetup)
// @Tag(Constants.xAzureSQLDB)
// @Tag(Constants.xAzureSQLDW)
// @Tag(Constants.xAzureSQLMI)
// public void testFourPartSyntaxCallEscapeSyntax() throws SQLException {
// String table = AbstractSQLGenerator.escapeIdentifier(RandomUtil.getIdentifier("serverList"));
// try {

// try (Statement stmt = connection.createStatement()) {
// TestUtils.dropTableIfExists(table, stmt);
// stmt.execute("CREATE TABLE " + table
// + " (serverName varchar(100),network varchar(100),serverStatus varchar(4000), id int, collation varchar(100), connectTimeout int, queryTimeout int)");
// stmt.execute("INSERT " + table + " EXEC sp_helpserver");

// ResultSet rs = stmt
// .executeQuery("SELECT COUNT(*) FROM " + table + " WHERE serverName = N'" + linkedServer + "'");
// rs.next();

// if (rs.getInt(1) == 1) {
// // Drop all linked logins associated with the server
// stmt.execute("EXEC sp_dropserver @server='" + linkedServer + "', @droplogins='droplogins';");
// }

// stmt.execute("EXEC sp_addlinkedserver @server='" + linkedServer + "';");
// stmt.execute("EXEC sp_addlinkedsrvlogin @rmtsrvname=N'" + linkedServer + "', @useself=false"
// + ", @rmtuser=N'" + linkedServerUser + "', @rmtpassword=N'" + linkedServerPassword + "'");
// stmt.execute("EXEC sp_serveroption '" + linkedServer + "', 'rpc', true;");
// stmt.execute("EXEC sp_serveroption '" + linkedServer + "', 'rpc out', true;");
// }

// SQLServerDataSource ds = new SQLServerDataSource();
// ds.setServerName(linkedServer);
// ds.setUser(linkedServerUser);
// ds.setPassword(linkedServerPassword);
// ds.setEncrypt(false);
// ds.setTrustServerCertificate(true);

// try (Connection linkedServerConnection = ds.getConnection();
// Statement stmt = linkedServerConnection.createStatement()) {
// stmt.execute(
// "create or alter procedure dbo.TestAdd(@Num1 int, @Num2 int, @Result int output) as begin set @Result = @Num1 + @Num2; end;");

// stmt.execute("create or alter procedure dbo.TestReturn(@Num1 int) as select @Num1 return @Num1*3 ");
// }

// try (CallableStatement cstmt = connection
// .prepareCall("{call [" + linkedServer + "].master.dbo.TestAdd(?,?,?)}")) {
// int sum = 11;
// int param0 = 1;
// int param1 = 10;
// cstmt.setInt(1, param0);
// cstmt.setInt(2, param1);
// cstmt.registerOutParameter(3, Types.INTEGER);
// cstmt.execute();
// assertEquals(sum, cstmt.getInt(3));
// }

// try (CallableStatement cstmt = connection
// .prepareCall("exec [" + linkedServer + "].master.dbo.TestAdd ?,?,?")) {
// int sum = 11;
// int param0 = 1;
// int param1 = 10;
// cstmt.setInt(1, param0);
// cstmt.setInt(2, param1);
// cstmt.registerOutParameter(3, Types.INTEGER);
// cstmt.execute();
// assertEquals(sum, cstmt.getInt(3));
// }

// try (CallableStatement cstmt = connection
// .prepareCall("{? = call [" + linkedServer + "].master.dbo.TestReturn(?)}")) {
// int expected = 15;
// cstmt.registerOutParameter(1, java.sql.Types.INTEGER);
// cstmt.setInt(2, 5);
// cstmt.execute();
// assertEquals(expected, cstmt.getInt(1));
// }
// } finally {
// try (Statement stmt = connection.createStatement()) {
// TestUtils.dropTableIfExists(table, stmt);
// }
// }
// }

@Test
public void testTimestampStringConversion() throws SQLException {
Expand Down