Skip to content

Conversation

@xadupre
Copy link
Member

@xadupre xadupre commented Jun 10, 2024

No description provided.

@xadupre xadupre marked this pull request as ready for review June 10, 2024 12:31
@xadupre xadupre requested a review from a team as a code owner June 10, 2024 12:31
@xadupre xadupre self-assigned this Jun 21, 2024
wschin
wschin previously approved these changes Jun 27, 2024
Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but please still fix the typo.

Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the math documentation covers all expected behaviors of the op (not only in this PR). They are the golden standard needed for code quality. Once you fix them, please ping me again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants