Skip to content

Conversation

sgallese
Copy link

@sgallese sgallese commented Aug 1, 2024

Issue
Main was passing arguments in the wrong order to transformers_and_bert

Fix
Pass arguments in correct order!

To reproduce
python -m onnxruntime_extensions.tools.add_pre_post_processing_to_model --model_type transformers --tokenizer_type BertTokenizer --nlp_task_type QuestionAnswering --vocab_file {vocab_file_path} {model_path}

Outputs:
FileNotFoundError: [Errno 2] No such file or directory: 'BertTokenizer'

Test
Placed transformers_and_bert under test.

But I couldn't figure out a way to easily test arguments passed to main. Open to suggestions!

@sgallese sgallese requested a review from a team as a code owner August 1, 2024 16:20
@sgallese
Copy link
Author

sgallese commented Aug 1, 2024

@microsoft-github-policy-service agree

@sayanshaw24
Copy link
Collaborator

/azp run onnxruntime-extensions.CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wenbingl
Copy link
Contributor

wenbingl commented Sep 4, 2024

@skottmckay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants