Skip to content

Add custom ops library_path to EP metadata #25830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

psakhamoori
Copy link
Contributor

@psakhamoori psakhamoori commented Aug 22, 2025

Summary

Adds EP metadata library path support to enable custom ops DLL registration with proper path resolution.

Changes

  • Added library_path metadata key to EP metadata infrastructure
  • Pass resolved library path directly to EpLibraryProviderBridge constructor
  • Simplified implementation per reviewer feedback (removed virtual method complexity)
  • Added #include <utility> for std::move compliance

Purpose

Enables downstream applications (like onnxruntime-genai) to resolve relative custom ops library paths using EP metadata, improving DLL registration reliability.

Files Modified

  • plugin_ep/ep_factory_provider_bridge.h
  • plugin_ep/ep_library.h
  • plugin_ep/ep_library_plugin.h
  • plugin_ep/ep_library_provider_bridge.cc
  • plugin_ep/ep_library_provider_bridge.h
  • utils.cc

@nieubank
Copy link
Contributor

It may be worth noting that this is not Vitis specific, the motivation may be for the custom ops dll loading scenario, but exposing the library path as metadata, generally speaking is goodness here.

@psakhamoori psakhamoori changed the title [VitisAI EP] Add custom ops library_path to EP metadata Add custom ops library_path to EP metadata Aug 22, 2025
Copy link

@chrisdMSFT chrisdMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants