Skip to content

Fix for micro benchmark build failure with c++20 #26299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix for micro benchmark build failure with c++20 #26299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d6dc0f
Fix for micro benchmark build failure with c++20
JonathanC-ARM Oct 14, 2025
0d9c24d
Merge branch 'microsoft:main' into jclohess_micro_benchmark_build_fix
JonathanC-ARM Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions onnxruntime/test/onnx/microbenchmark/tptest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ BENCHMARK(BM_CreateThreadPool)
#pragma GCC optimize("O0")
#endif
void SimpleForLoop(ptrdiff_t first, ptrdiff_t last) {
size_t sum = 0;
[[maybe_unused]] size_t sum = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the compiler is warning about it, could it also be "smart" enough to optimize it away? should we also do something similar to the other change in the PR with benchmark::DoNotOptimize()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah possibly worth doing that, its unclear what the compiler will do. Its possible that its optimizing it away in older versions where this warning isn't being thrown. But I will check if benchmark::DoNotOptimize(sum) silences the warning and if so i'll make that change. (I assume it will)

for (; first != last; ++first) {
++sum;
}
Expand Down Expand Up @@ -102,7 +102,8 @@ static void BM_ThreadPoolSimpleParallelFor(benchmark::State& state) {
for (auto _ : state) {
for (int j = 0; j < 100; j++) {
ThreadPool::TrySimpleParallelFor(tp.get(), len, [&](size_t) {
for (volatile size_t x = 0; x < body; x++) {
for (size_t x = 0; x < body; x++) {
benchmark::DoNotOptimize(x);
}
});
}
Expand Down
Loading