Skip to content

chore(debug controller): add per-browser highlight + close #37061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 15, 2025

My UI will have per-browser buttons for picking a locator and closing a browser.

@Skn0tt Skn0tt requested a review from dgozman August 15, 2025 14:10
@Skn0tt Skn0tt self-assigned this Aug 15, 2025
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [webkit-page] › page/page-navigation.spec.ts:28 › should work with cross-process _blank target @webkit-ubuntu-22.04-node18

19 flaky ⚠️ [chromium-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@chromium-ubuntu-22.04-node18`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node18`
⚠️ [chromium-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/page-clock.frozen.spec.ts:19 › clock should be frozen `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:114 › reuse connect › should reset serviceworker `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:23 › should generate aria snapshot `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node18`
⚠️ [chromium-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/inspector/console-api.spec.ts:38 › should support playwright.$, playwright.$$ `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [webkit-library] › library/browsercontext-basic.spec.ts:190 › should not report frameless pages on error `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/debug-controller.spec.ts:389 › should work with browser._launchServer `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/debug-controller.spec.ts:418 › should support closing browsers `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:24 › cli codegen › should contain open page `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-navigation.spec.ts:20 › should work with _blank target `@webkit-ubuntu-22.04-node18`

46612 passed, 801 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant