Skip to content

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Jul 30, 2025

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.

Resolves [Add Relevant Issue Here]

What

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.

Screenshots

Add any relevant screen captures here from before or after your changes.

Testing

If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

Optional: Describe the tests that you ran locally to verify your changes.

Changelog

Should this change be included in the release notes: indicate yes or no

Add a brief summary of the change to use in the release notes for the next release.

Microsoft Reviewers: Open in CodeFlow

@@ -23,18 +26,54 @@ if (!email) {
process.exit(1);
}

const child = child_process.exec(`npm adduser${registry? (' --registry ' + registry) :''}` );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

child.stdin.write waits for prompts that never properly complete , for node 22 and verdaccio and its not itermittent in nature hence added non-interactive approach using npm config set commands to set authentication

@@ -71,16 +71,16 @@ if not "%part%"=="" (
:loopend

if %USE_VERDACCIO% equ 1 (
@echo creaternwapp.cmd: Setting npm to use verdaccio at http://localhost:4873
call npm config set registry http://localhost:4873
@echo creaternwapp.cmd: Setting yarn to use verdaccio at http://localhost:4873
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all npm commands and replaced with yarn equivalent as workaround for npm 10.5.1 has a bug with Verdaccio that causes ECONNREFUSED errors particular to node version >= 21 ( we updated to 22) .

@iamAbhi-916 iamAbhi-916 deleted the node22-vmtest branch August 24, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants