-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[TEST] Test the new node 22 VM #14984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -23,18 +26,54 @@ if (!email) { | |||
process.exit(1); | |||
} | |||
|
|||
const child = child_process.exec(`npm adduser${registry? (' --registry ' + registry) :''}` ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
child.stdin.write waits for prompts that never properly complete , for node 22 and verdaccio and its not itermittent in nature hence added non-interactive approach using npm config set
commands to set authentication
@@ -71,16 +71,16 @@ if not "%part%"=="" ( | |||
:loopend | |||
|
|||
if %USE_VERDACCIO% equ 1 ( | |||
@echo creaternwapp.cmd: Setting npm to use verdaccio at http://localhost:4873 | |||
call npm config set registry http://localhost:4873 | |||
@echo creaternwapp.cmd: Setting yarn to use verdaccio at http://localhost:4873 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed all npm commands and replaced with yarn equivalent as workaround for npm 10.5.1 has a bug with Verdaccio that causes ECONNREFUSED errors particular to node version >= 21 ( we updated to 22) .
Description
Type of Change
Erase all that don't apply.
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Changelog
Should this change be included in the release notes: indicate yes or no
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow