-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix ARM64 support in rnw-dependencies.ps1 for Visual Studio component installation #15222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ection Co-authored-by: sundaramramaswamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@copilot run command yarn change or npm change at the root of the repo, and provide the requested details. |
Co-authored-by: vineethkuttan <[email protected]>
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@sundaramramaswamy did you test this script in a new ARM machine? To confirm whether it is working fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Original prompt
This section details on the original issue you should resolve
<issue_title>Unable to build gallery on a fresh ARM64 machine</issue_title>
<issue_description>I've Visual Studio 2022, Git, Node and Yarn installed. Ran
./node_modules/react-native-windows/Scripts/rnw-dependencies.ps1from an elevated Powershell.yarn windowsfails to build due tonode_modules\@react-native-clipboard\clipboard\windows\Clipboard\Clipboard.vcxprojfailing to build.Of course, trying
npx react-native run-windows --loggingshows the same error since this is a C++ project build issue.</issue_description><agent_instructions>Switch to
Microsoft.VisualStudio.Component.VC.Tools.ARM64instead ofMicrosoft.VisualStudio.Component.VC.Tools.x86.x64if the machine architecture is ARM64 in the file//vnext/Scripts/rnw-dependencies.ps1.</agent_instructions>Comments on the Issue (you are @copilot in this section)
@sundaramramaswamy Digging deeper, `node_modules/react-native-windows/Scripts/rnw-dependencies.ps1` doesn't install the expected Windows SDK 10.0.22621.0 on this ARM64 machine. Machine detailsThis SDK is needed by
clipboard.vcxprojvianode_modules/react-native-windows/PropertySheets/External/Microsoft.ReactNative.WindowsSdk.Default.props.</comment_new><comment_new>@sundaramramaswamy
rnw-dependencies.ps1assumes machine architecture (x86/64) and hence tries to installMicrosoft.VisualStudio.Component.VC.Tools.x86.x64instead ofMicrosoft.VisualStudio.Component.VC.Tools.ARM64.</comment_new>💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Microsoft Reviewers: Open in CodeFlow