Skip to content

Conversation

agoryuno
Copy link

@agoryuno agoryuno commented Jul 10, 2023

I've rewritten the torchscale.architecture.config module to use inheritance and remove the redundant code. There are now 3 classes:

Config - that holds all common options
EncoderConfig - inherits 'Config' and holds Encoder specific options
DecoderConfig - inherits 'Config' and holds Decoder specific options
EncoderDecoderConfig - inherits EncoderConfig and DecoderConfig and holds that one option shared by Encoder and Decoder objects.

I also took the liberty to add some type hints for args parameters in encoder/decoder modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant