Adding ability to resize grid columns in results #20335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20335 +/- ##
==========================================
- Coverage 54.55% 54.54% -0.02%
==========================================
Files 200 200
Lines 17308 17308
Branches 1149 1149
==========================================
- Hits 9442 9440 -2
- Misses 7866 7868 +2 🚀 New features to boost your workflow:
|
Benjin
reviewed
Oct 24, 2025
| selectPublishProfile: () => void; | ||
| savePublishProfile: (profileName: string) => void; | ||
| } | ||
| /*--------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Yeah, I think this was using an old line ending. Merging from main and committing this change caused it to fix its formatting. Undoing this change for this PR.
| } | ||
|
|
||
| // Resize column (Shift+Alt+S) | ||
| if (keyCode === KeyCode.KeyS && e.shiftKey && e.altKey && !metaOrCtrlPressed) { |
There was a problem hiding this comment.
Would be nice for readability if the checks were the same order as the shortcut description
src/reactviews/pages/QueryResult/table/plugins/cellSelectionModel.plugin.ts
Outdated
Show resolved
Hide resolved
Benjin
previously approved these changes
Oct 24, 2025
added 2 commits
October 23, 2025 22:18
added 2 commits
October 23, 2025 22:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
Entry points:
Dialog:
Validation error:
Fixes: #19822
Currently we cannot provide single pointer resizing as that will require big modifications to the grid. Providing an alternate way to change the grid column size using keyboard input should be a good enough alternative.
Bump to latest fluent react package. This fixes a bug of adhoc dialogs not showing up
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines