Fix NVDA double label announcement in Table Designer input fields #20338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where NVDA screen reader announces label names twice for input fields and text areas throughout the Table Designer, causing poor accessibility for screen reader users.
Problem
Screen reader users experience cognitive overload and confusion due to redundant label announcements. For example, when focusing on a column name input field, NVDA would announce:
This behavior was consistent across all input fields and text areas in the Table Designer, significantly impacting the user experience for users relying on auditory feedback.
Root Cause
The
designerInputBox.tsxcomponent was creating duplicate ARIA label associations:Fieldcomponent with alabelprop automatically associates the label with its child input elements through proper ARIA attributesaria-labelledbyattributes were manually added to bothInputandTextareacomponents, referencing a generated IDThis double association caused screen readers to announce the label twice—once from the Field's automatic handling and once from the explicit
aria-labelledbyattribute.Solution
Removed redundant
aria-labelledbyattributes from Input and Textarea components indesignerInputBox.tsx. The Fluent UI Field component already handles accessibility associations correctly through its internal implementation, making the explicit attributes unnecessary and harmful.Changes:
useIdimport (no longer needed)dropdownIdvariable declarationaria-labelledbyattribute fromInputcomponentaria-labelledbyattribute fromTextareacomponentImpact
Testing
Fixes #[issue_number]
GitHub Tags: #A11yTCS, #MSSQL for VSCode, #A11ySev3, #WCAG1.3.1, #NVDA, #A11yMAS
Original prompt
Fixes #19814
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.