-
Notifications
You must be signed in to change notification settings - Fork 542
Publish Dialog - Advanced deployment options #20346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
136 commits
Select commit
Hold shift + click to select a range
a4159d7
intial changes to load empty dialog
ssreerama cc2167f
UI intial changes
ssreerama 94f8dae
advanced options added
ssreerama 463b2e8
basic UI final changes
ssreerama f75c54c
UI changes with formwebviewcontroller
ssreerama a6c2545
Basic UI final changes
ssreerama 90844a1
Merge branch 'sai/vscodePublishDialog' of https://github.com/microsof…
ssreerama 6e1970c
removed Advanced related changes from the current set
ssreerama 13b93a9
converting const to static class
ssreerama 28fc897
localized files
ssreerama 0c24390
copilot comments adjusted
ssreerama 6c85bdd
using new webview provider
ssreerama c091477
updating the code
ssreerama 8f586c8
Adding publish dialog basic test file
ssreerama 0e24de1
Merge branch 'main' into sai/vscodePublishDialog
ssreerama 6e5aa69
adding target field changes
ssreerama bba6d85
revert service instnace update and add loc fiels
ssreerama 3f7eeff
addressing code review comments
ssreerama 7d95c74
Merge branch 'main' into sai/vscodePublishDialog
ssreerama 4415ad2
Merge branch 'sai/vscodePublishDialog' into sai/vscodePublishDialog_1…
ssreerama db5f691
adding tests that covers the target field
ssreerama 561fda8
copilot review updates
ssreerama 73d1926
little refactoring
ssreerama 1108c73
updating the variable name
ssreerama 407e740
Merge branch 'sai/vscodePublishDialog' into sai/vscodePublishDialog_1…
ssreerama 9d5bdb9
addressing code review comments
ssreerama 4929b34
updating LOC and fixing test
ssreerama 978735e
merging the base pr changes and little bit of refactoring
ssreerama 78b6117
confirm password validation with both pwd fields
ssreerama 00c2965
addressing code review comments
ssreerama 7392e72
undo double wrapping
ssreerama 41b022b
rebase on intial setup PR with modification
ssreerama a74ee8c
loc updates
ssreerama 91fb9d7
Merge branch 'main' into sai/vscodePublishDialog
ssreerama 669394c
Merge branch 'sai/vscodePublishDialog' into sai/vscodePublishDialog_1…
ssreerama c016d0f
adding tests
ssreerama eaf3918
checkbox alignment
ssreerama fe73219
Merge branch 'main' into sai/vscodePublishDialog
ssreerama ffb206c
Merge branch 'sai/vscodePublishDialog' into sai/vscodePublishDialog_1…
ssreerama 4510b80
Merge branch 'main' into sai/vscodePublishDialog
ssreerama 9e25ee2
Merge branch 'main' into sai/vscodePublishDialog
ssreerama af8f986
Merge branch 'main' into sai/vscodePublishDialog
ssreerama 6d4f032
adding main controller test to validate publish proj call
ssreerama fb60764
Merge branch 'sai/vscodePublishDialog' into sai/vscodePublishDialog_1…
ssreerama 26623a6
LOC update
ssreerama 017e042
Merge branch 'main' into sai/vscodePublishDialog_1Target
ssreerama 34a1054
fixing the issues caused due to resolve conflicts
ssreerama 89b5f4d
fixing tests
ssreerama f098fdd
refactoring
ssreerama f0b216a
fixing build errors
ssreerama 5850736
moving to utils and constants
ssreerama 0cf7041
removing multi tests and adding clear comments for the methods
ssreerama 83e4b60
renaming profileName to publishprofileName for clear understanding
ssreerama 1007b90
refactoring for options
ssreerama 728ae14
intial commit to add select publish profile reducer that opens and se…
ssreerama 0477e1d
moving parseHtmlLabel method to react view utils file
ssreerama bc499a3
save profile onclick and saving the xml, without connectionstring
ssreerama c655422
Merge branch 'sai/vscodePublishDialog_1Target' into sai/vscodePublish…
ssreerama bbb1500
format updates and save button logic update
ssreerama 2f20abd
adding tests for select and save profile
ssreerama efc107b
Merge branch 'main' into sai/vscodePublishDialog_1Target
ssreerama 6136b3d
Merge branch 'sai/vscodePublishDialog_1Target' into sai/vscodePublish…
ssreerama 95e62d6
Using required constants throught the shared interfaces.
ssreerama e69f0dd
Merge branch 'sai/vscodePublishDialog_1Target' into sai/vscodePublish…
ssreerama 39e5d45
adding telemetry
ssreerama 147a406
exclude options are default to empty, add upon selection
ssreerama ff917e9
reading publish.xml on selct profile
ssreerama 594feda
removing unsed method
ssreerama b330729
Merge branch 'sai/vscodePublishDialog_1Target' into sai/vscodePublish…
ssreerama d1abe67
Final changes for the profile section
ssreerama de953ca
LOC missing changes addding back
ssreerama 6b7b582
adding icon and disabling server input
ssreerama b970759
connection work
ssreerama e580db5
LOC
ssreerama 156fa69
adding conneciton string to the state and saving in profile
ssreerama d279530
copilot review updates
ssreerama 5b78e17
Merge branch 'sai/vscodePublishDialog_1Target' into sai/vscodePublish…
ssreerama 778961c
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 70616cf
reverting sqlprojservice to optional
ssreerama 6daeb77
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 6c2264e
combobox style fixes
ssreerama e671f61
saving selected DB
ssreerama 24a1ea1
adding tests
ssreerama 8d7bee6
preserving database options and value on target switch
ssreerama 0be7012
fixing the stabilize conneciton switching issue
ssreerama 9c46c16
adding placeholder
ssreerama 2f810ec
LOC
ssreerama 890c708
making conn string empty for container
ssreerama 5ffb1e0
addressing copilot code suggestions
ssreerama 6267375
advanced drawer initial implementation
ssreerama 722110e
Loc
ssreerama a33be73
using onsuccessfulconneciton responce
ssreerama 888cf07
Merge branch 'main' into sai/vscodePublishDialog_2Profile
ssreerama 39bb3f3
Loc
ssreerama 86ae055
removing dockerUtils file
ssreerama 945c504
update read sqlcmd variabled from profile using the xmlDom parser
ssreerama 1481733
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 91a3920
typo updates and guard check added
ssreerama 7a47f30
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 2a9dc0d
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama a79bc6b
connection null check
ssreerama e14e9be
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 0eb7979
optimizing the validation logic
ssreerama f55ee14
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 059c0bc
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 962dde4
fixing the duplicate afterSetFormProperty methods
ssreerama c5fc619
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 2ae2d40
ignore option group added
ssreerama d97d352
LOC
ssreerama 5e4e950
moving method to Utils
ssreerama 44966d4
Merge branch 'sai/vscodePublishDialog_2Profile' into sai/vscodePublis…
ssreerama 23dae46
Merge branch 'main' into sai/vscodePublishDialog_3ServerConnection
ssreerama 87b3190
logging when database connection fails
ssreerama 2e0af22
handle new connection details updates
ssreerama c75432d
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 809ddaf
test fixes
ssreerama f210b46
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 01c1dbc
all are done except update profile and save profile changes with opti…
ssreerama 4adadcb
removed unnecessary advancedgroup options state
ssreerama 8c0288e
test updates
ssreerama c7c0490
fixing the reset button and refactoring the comments
ssreerama f31b41e
final changes
ssreerama a8560b3
Merge branch 'main' into sai/vscodePublishDialog_3ServerConnection
ssreerama 23d85b1
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 430f082
removing additional div element that disturbs the alignment
ssreerama c83e41b
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 94f9924
cleanup
ssreerama 35493ef
Merge branch 'sai/vscodePublishDialog_3ServerConnection' into sai/vsc…
ssreerama 37529d1
Merge branch 'main' into sai/vscodePublishDialog_4AdvancedOption
ssreerama d25af5b
final refactoring
ssreerama a8ee484
test fix and redundant state update removed
ssreerama 282f7b9
Merge branch 'main' into sai/vscodePublishDialog_4AdvancedOption
ssreerama 22aa1a5
updates and loc
ssreerama 3f2a5c1
Merge branch 'main' into sai/vscodePublishDialog_4AdvancedOption
ssreerama 9e8d9b9
addressing review comments by refactoring and updating tests
ssreerama 890f0fa
Merge branch 'main' into sai/vscodePublishDialog_4AdvancedOption
ssreerama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need
as const? what does that do here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no use its just a string value, added by formatting the code using copilot. I'll remove it