Skip to content

Conversation

@Benjin
Copy link
Contributor

@Benjin Benjin commented Oct 23, 2025

Description

Fixes an issue where after an Entra token expires and the user is prompted to re-authenticate, the new token isn't persisted to the OE node's copy of the connection profile. This results in many reauth prompts for sessions that last beyond the initial Entra token's lifespan.

Fixes #19869
Fixes #19931

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 56.54% 55.91% ⚪ 0.00%
VSIX Size 4869 KB 4860 KB ⚪ -9 KB ( 0% )
Webview Bundle Size 4024 KB 4012 KB ⚪ -12 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.95%. Comparing base (7e1cf01) to head (2aa1bea).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/connectionManager.ts 0.00% 6 Missing ⚠️
src/controllers/mainController.ts 0.00% 5 Missing ⚠️
src/controllers/sqlDocumentService.ts 81.81% 2 Missing ⚠️
src/schemaDesigner/schemaDesignerWebviewManager.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (63.15%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20352      +/-   ##
==========================================
+ Coverage   53.91%   53.95%   +0.03%     
==========================================
  Files         198      198              
  Lines       17125    17156      +31     
  Branches     1140     1141       +1     
==========================================
+ Hits         9233     9256      +23     
- Misses       7892     7900       +8     
Files with missing lines Coverage Δ
src/objectExplorer/nodes/treeNodeInfo.ts 95.83% <100.00%> (+3.94%) ⬆️
...rc/tableDesigner/tableDesignerWebviewController.ts 75.65% <100.00%> (+0.16%) ⬆️
src/utils/utils.ts 74.07% <100.00%> (+2.64%) ⬆️
src/schemaDesigner/schemaDesignerWebviewManager.ts 14.28% <0.00%> (-0.35%) ⬇️
src/controllers/sqlDocumentService.ts 85.86% <81.81%> (-0.65%) ⬇️
src/controllers/mainController.ts 16.08% <0.00%> (-0.05%) ⬇️
src/controllers/connectionManager.ts 43.13% <0.00%> (-0.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reauthentication prompts very frequesntly [Bug]: Azure SQL + Entra MFA → re-authentication required for every new query tab

4 participants