WIP Begin support on windows #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested, but compiles
|
Compiles successfully on windows with some warnings |
|
Paths on windows for now aren't fixed |
|
Since as you mentioned it's unclear what the impact on Linux is, it's probably better to keep this PR as a reference for now. For merging, we'd want to confirm all functionality is working on Windows and we'd want to do more cross-platform testing to ensure the Linux build isn't regressing. It's really useful to know where Windows is struggling with though (and glad to see it doesn't require too many changes), so thanks for having looked into this! |
|
I didn't test it fully and I can't determine what the other errors are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, probably wont compile on linux.