Skip to content

💥 ♻️ ✨ prepare v2 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 9, 2025
Merged

💥 ♻️ ✨ prepare v2 #141

merged 9 commits into from
Sep 9, 2025

Conversation

ianardee
Copy link
Collaborator

@ianardee ianardee commented Sep 9, 2025 •
edited
Loading

Description

  • 💥 drop support for PHP 7.4
  • ♻️ use enum instead of horrible classes
  • 💥 drop support for API Builder
  • ✨ fixPDF should be independant of client
  • ♻️ add some named params

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@ianardee ianardee force-pushed the update-versions branch 3 times, most recently from acfcf7e to 9a52533 Compare September 9, 2025 12:02
@ianardee ianardee changed the title 💥 drop support for PHP 7.4 💥 prepare v2 Sep 9, 2025
@ianardee ianardee changed the title 💥 prepare v2 💥 ♻️ ✨ prepare v2 Sep 9, 2025
@ianardee ianardee marked this pull request as ready for review September 9, 2025 15:48
sebolivera
sebolivera approved these changes Sep 9, 2025
View reviewed changes
Copy link

@sebolivera sebolivera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong account, correct feedback below.

sebastianMindee
sebastianMindee approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@sebastianMindee sebastianMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the proper account 🤦

@ianardee ianardee merged commit adf2e79 into main Sep 9, 2025
28 checks passed
@ianardee ianardee deleted the update-versions branch September 9, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianMindee sebastianMindee sebastianMindee approved these changes

+1 more reviewer

@sebolivera sebolivera sebolivera approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianardee @sebolivera @sebastianMindee