Skip to content

Add region, extra_headers and extra_query_params #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

Add region, extra_headers and extra_query_params #1505

merged 1 commit into from
Oct 11, 2025

Conversation

@balamurugana
Copy link
Member

@balamurugana balamurugana commented Aug 7, 2025 •
edited
Loading

  • Now all APIs accepts region, extra_headers and extra_query_params additional arguments for more control.
  • Add checksum support

@balamurugana balamurugana marked this pull request as draft August 7, 2025 09:11
@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch 15 times, most recently from d1f7ade to 32797f3 Compare August 11, 2025 00:48
@balamurugana balamurugana self-assigned this Aug 12, 2025
@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch from 32797f3 to 6756df1 Compare September 1, 2025 04:18
@balamurugana balamurugana marked this pull request as ready for review September 1, 2025 04:29
csumisha
csumisha requested changes Sep 18, 2025
View reviewed changes
Copy link

@csumisha csumisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated method definitions have not been reflected in the sample provided in api.py, documentation, and examples. It has to be fixed.

@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch 4 times, most recently from f473f2f to f018d84 Compare September 18, 2025 16:03
sivanantham-gnanavel
sivanantham-gnanavel requested changes Sep 18, 2025
View reviewed changes
Copy link

@sivanantham-gnanavel sivanantham-gnanavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update API.md and README.md for:

  • Minio() → keyword-only arguments
  • metadata → user_metadata

minio/api.py
region = self._get_region(bucket_name)
region = self._get_region(
bucket_name=bucket_name,
region=region,
Copy link

@sivanantham-gnanavel sivanantham-gnanavel Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: extra_headers and extra_query_params

@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch 2 times, most recently from 4a7e0ff to a665857 Compare September 24, 2025 04:00
@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch 2 times, most recently from be2de6b to eb1ce77 Compare September 30, 2025 03:28
@balamurugana
Copy link
Member Author

balamurugana commented Sep 30, 2025

@csumisha @sivanantham-gnanavel fixed docs

ebozduman
ebozduman reviewed Oct 2, 2025
View reviewed changes
ebozduman
ebozduman reviewed Oct 2, 2025
View reviewed changes
rraulinio
rraulinio requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@rraulinio rraulinio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good job! I do have a few concerns here. First and foremost, this PR implies major version bump for anyone updating as such. Is that expected? Thank you! 😇

@balamurugana
Copy link
Member Author

balamurugana commented Oct 2, 2025

Overall, good job! I do have a few concerns here. First and foremost, this PR implies major version bump for anyone updating as such. Is that expected? Thank you! 😇

@rraulinio Yes. It is a breaking change and leads to major version upgrade i.e. v8.0.0. The version number will be set at the time of release.

ebozduman
ebozduman previously approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rraulinio
rraulinio previously approved these changes Oct 3, 2025
View reviewed changes
sivanantham-gnanavel
sivanantham-gnanavel previously approved these changes Oct 8, 2025
View reviewed changes
Copy link

@sivanantham-gnanavel sivanantham-gnanavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csumisha
csumisha requested changes Oct 8, 2025
View reviewed changes
Copy link

@csumisha csumisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md. README_zh_CN.md, docs/zh_CN/API.md still have the old functional call. Please fix those.

@balamurugana balamurugana requested a review from csumisha October 8, 2025 13:31
@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch from eb1ce77 to fdfb021 Compare October 8, 2025 13:39
@balamurugana
Add region, extra_headers and extra_query_params
613785f 
Now all APIs accepts region, extra_headers and extra_query_params
additional arguments for more control.

Signed-off-by: Bala.FA <[email protected]>
@balamurugana balamurugana force-pushed the Add-region-extra_headers-and-extra_query_params branch from fdfb021 to 613785f Compare October 8, 2025 13:43
csumisha
csumisha requested changes Oct 8, 2025
View reviewed changes
Copy link

@csumisha csumisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix here README_zh_CN.md - line no 42 and docs/zh_CN/API.md line no 11 and 23

@csumisha
Copy link

csumisha commented Oct 9, 2025

Can we fix here README_zh_CN.md - line no 42 and docs/zh_CN/API.md line no 11 and 23

@balamurugana as per our discussion, we will not be fixing these since these docs are not valid anymore.

@harshavardhana harshavardhana merged commit 6daf366 into minio:master Oct 11, 2025
15 checks passed
@balamurugana balamurugana deleted the Add-region-extra_headers-and-extra_query_params branch October 15, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebozduman ebozduman ebozduman approved these changes

@csumisha csumisha csumisha approved these changes

@rraulinio rraulinio rraulinio left review comments

@sivanantham-gnanavel sivanantham-gnanavel sivanantham-gnanavel left review comments

@donatello donatello Awaiting requested review from donatello

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@kannappanr kannappanr Awaiting requested review from kannappanr

Assignees

@balamurugana balamurugana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@balamurugana @csumisha @rraulinio @ebozduman @sivanantham-gnanavel @harshavardhana