-
Notifications
You must be signed in to change notification settings - Fork 43
[WIP] v0.5.0 #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] v0.5.0 #137
Conversation
|
At the moment, there appears to be an issue with Mitsuba picking up Blender's embree library (version 4). I can work around by running with LD_PRELOAD, but probably that's not ideal: LD_PRELOAD=~/code/mitsuba3/build/blender-dbg/libembree3.so $BLENDER -b -noaudio --factory-startup --python scripts/run_tests.py --mitsuba ~/code/mitsuba3/build/blender-dbg/ -- -v --cov=mitsuba-blender@bathal1 How come this wasn't an issue in the past? Any idea? |
|
The embree symbol issue was now fixed in Mitsuba itself: mitsuba-renderer/mitsuba3#1663 |
|
I'll be pushing some commits to prepare for the next release of the add-on here @dvicini. Regarding testing, it would be nice to add more extensive round-trip tests. IIRC we also only test one round-trip, but two might pose an issue. For example, exporting a scene from blender will wrap all BSDFs into |
|
Sounds good! I don't have local changes, feel free to use this branch. We can later maybe cleanup the history a bit and squash some of my earlier commits into fewer ones. For testing: Not just round trip tests, but it would also be good to more rigorously test that the renderings match. For example, Blender at some point changed its definition of the light source intensities, which leads to very different outputs if not handled correctly. My suggestion would be to test some of those things by programmatically creating simple blender scenes, rendering them, exporting, and rendering with Mitsuba and comparing final images. |
|
By the way, is #105 (same title) deprecated or should it be combined with this PR? |
f0857c0 to
c22f631
Compare
4bf8a0d to
c2d99e6
Compare
…in Mitsuba 3. This allows to significantly simplify the importer logic, as most of it is now handled directly by Mitsuba
…w loaded as (by-default) two-sided blender materials, regardless of whether they are nested in a twosided plugin or not
9b4d664 to
12d0644
Compare
b974e5f to
691f0b4
Compare
This PR updates the plugin to use the latest Mitsuba APIs. Mainly, the Properties API has been slightly modified.
Moreover, it improves the testing scripts to better support local runs of unit tests.
(work in progress, not yet ready to merge. This will require a Mitsuba release to use the latest APIs)