-
Notifications
You must be signed in to change notification settings - Fork 296
Ray loader to support mini-batch training #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @ziyi-zhang, I haven't ready the implementation so maybe this is already supported, but one feature that could be quite helpful: ensure that rays can be sampled as e.g. 2x2, 4x4, etc tiles from the same sensor. The user could select the tile size to get more or less coherence. |
Hi @merlinND, Good point. What do you think is the best solution if the film size is not divisible by the patch size, e.g., 4x4 patch for a 12x10 film? |
Hi @ziyi-zhang, I haven't checked the implementation, but it sounds like you are trying to exhaustively enumerate all batches (and maybe now all NxN ray tiles) out of the total pixels, without overlap. |
2abf849
to
5c36e66
Compare
This PR introduces a ray loader that wraps a list of sensors to enable mini-batch optimization.
The sampling strategy aims to uniformly cover all pixels before reshuffling (i.e., permutation-based sampling), but this is not strictly guaranteed when a tile size is specified.
TODO
pixels_per_batch
.