Do not recompute normals if they were provided explicitly #1762
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvicini
force-pushed
the
mesh_normals_fix
branch
from
db68fcd to
e77a36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mesh class currently always recomputes vertex normals if the positions were modified. However, there can be cases where the user obtains vertex normals separately and would like to pass them to the mesh. In that case, we should not recompute the vertex normals. The assumption is then that the user "knows what they are doing" and the values should remain unchanged.
An application of this are for example meshes with smooth normals that have UV seams. In this case, the normals should remain smooth across UV seams.