Update to latest nanobind and python 3.12 support #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtourolle
changed the title
wjakob
force-pushed
the
master
branch
9 times, most recently
from
654b8a5 to
1cbff2e
Compare
wjakob
force-pushed
the
master
branch
18 times, most recently
from
6497f59 to
2f2e29f
Compare
wjakob
force-pushed
the
master
branch
7 times, most recently
from
c75898b to
1bbd038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small change that updates the nanobind submodule to the current master (probably a bad idea, maybe a fixed version would be preferred?) and then changes some code around the Flags enum for buttons to get it working.
Why were these changes needed? The Flags enum was treated as an integer by some functions. It seems with the latests nanobind there has been some changes to the handling of enums, which meant the casting of a enum in python to an int for the bound function does not work. This is possible related to this.
The solution I found was to change the functions to accept enums and perform static_casts when int->enum is needed.