Support for SQL INTERVAL Types by mapping to two distinct Python types #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job coming up with a reasonable interface: month & microsecond. Can you add some unit tests for at least SQL Server and PostgreSQL for these before we merge? |
|
@mkleehammer FYI SQL Server has no interval types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL
INTERVALtypes are classified into two distinct groups -- one that has month as the most granular time period and the other which has microsecond as the most granular time period. Per the SQL standard, it is meaningless to convert from one group of interval types to the other and thus is not permitted.This PR provides support for these two groups of SQL
INTERVALtypes by mapping them to Pythonint(number of months) anddatetime.timedeltarespectively as their canonical representations.