Support tracing-opentelemetry 0.32 #30
Open
+82
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse-Bakker
force-pushed
the
tracing-opentelemetry-0-32
branch
from
ab51932 to
cd516a3
Compare
|
Whoops, ran cargo check with the wrong feature set locally 🙈 |
|
I'll deal with the Just so you know, I'm happy to merge this as is, but there are some issues with starting the context which might be helped by tokio-rs/tracing-opentelemetry#234 so I'm wondering if I want to wait for that or not (though it's waiting for me). Do you need a release early? |
|
No need to rush a release from our side. We're currently on a fork for context activation because we rely on context access from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.