[Fix] Fix the optimization for TagDispatch and SubGrammarAdder. #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a concurrency issue in the TagDispatch optimization by converting a class member variable to a local variable that is passed by reference to the optimization function. This eliminates potential race conditions when multiple threads access the optimization data structure.
Key Changes:
- Moved the
tag_dispatch_rule_id_to_second_slicing_bitsetfrom a class member to a local variable - Extracted the TagDispatch optimization logic into a separate method that accepts the map by pointer parameter
- Added documentation for the new
TagDispatchOptimizationmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Seven-Streams
force-pushed
the
fix/2025-11-07/tag_optim
branch
from
a86d04d to
674f2f4
Compare
Seven-Streams
changed the title
Ubospica
reviewed
Nov 16, 2025
Collaborator
Ubospica
left a comment
Ubospica
left a comment
There was a problem hiding this comment.
Please see if you can reproduce it, even though the running time of the test is large. We can consider putting heavy tests in a daily efficiency test.
Ubospica
approved these changes
Nov 16, 2025
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Seven-Streams
force-pushed
the
fix/2025-11-07/tag_optim
branch
from
6d53e3a to
7c2cfd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency problem in the optimization for TagDispatch, and fixes a bug in
SubGrammarAdder.