Skip to content

Conversation

v-shobhit
Copy link

Cosmetic changes for ease of reproduction of benchmark results.

  • Removing names of internal resources that shouldn't be visible to the public.
  • Adding a TLDR section for users to quickly reproduce results.

Cosmetic changes for ease of reproduction
@v-shobhit v-shobhit requested review from a team as code owners May 6, 2025 01:40
Copy link

github-actions bot commented May 6, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@v-shobhit
Copy link
Author

@mrmhodak @swasson488 please consider this MR for updating NVIDIA's documentation.

@mrmhodak
Copy link
Contributor

mrmhodak commented May 6, 2025

Please provide:

  1. Description of changes; There is a large block of instructions removed and replaced by a different one.
  2. Why is this needed? The README had been reviewed, we should not been adding non-reviewed content unless fixing an issue.

If this is modifying instructions (be it for a better reproducibility or a different reason), I do not think we should be doing this past submision. This repo has been approved by peer review, we should not be introducing changes (other than bug fixes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants