Skip to content

Conversation

@ChaosPower
Copy link

I have added api version to service factory and config file. Lusitanian updated their servicefactory to cater api versions.

Please see hash 9baed43

@mmanos
Copy link
Owner

mmanos commented Nov 19, 2014

Hey, thanks for this. If you'll make a few changes I'll merge this in:

  • Don't modify the composer.json file.
  • I guess you have a forked, modified version of phpoauthlib? I would rather stick with the original.
  • Remove all changes where you trimmed trailing whitespace.
  • Use snake case for variables (eg. api_version not apiVersion).
  • Rebase all commits into one.

@ChaosPower
Copy link
Author

Thanks will do this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants