Skip to content

Conversation

@marlenas
Copy link

@marlenas marlenas commented Mar 26, 2018

Hi,

I needed a new functionality connected with adding an event when a new job is created.

I solved it on my branch. I issue a pull request, because I think that this functionality can be useful to others in the future.

Regards.

@mmucklo
Copy link
Owner

mmucklo commented Mar 29, 2018

This seems to be a reasonable request. And the implementation seems thorough enough, my one concern is the number changes required.

I'd like to review it a little bit to see if there's maybe a bit less obtrusive way.

Thanks for your PR, though.

@mmucklo
Copy link
Owner

mmucklo commented Mar 29, 2018

There's another issue I think - what happens when a job is created, but then "batched". Technically a job was created, but it was never saved into the queue as there was a pre-existing job that it was "batched" into.

Should there be a create event at that point? Should we have distinguishing events?

@marlenas
Copy link
Author

I apologise for not replying the message sooner.

With reference to your message, I did not predict such a situation, but I think that these events should be distinguished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants