-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[MRG] PCA flip for volumetric source estimates #13092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shrecki
wants to merge
30
commits into
mne-tools:main
Choose a base branch
from
Shrecki:pca_flip_volume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
bcc07f1
example description update.
Shrecki 99b593a
pca_flip allowed for volumetric
Shrecki 00e0487
[FEAT] Volumetric PCA flip implementation
Shrecki 3b3b754
Merge remote-tracking branch 'upstream/main'
Shrecki d88591f
Merge branch 'main' into pca_flip_volume
Shrecki 2e56dcb
Removed source_space_custom_atlas example - should be object of separ…
Shrecki a677854
[MISC] Changelog update
Shrecki 8a74ffe
[MISC] Fixed changelog
Shrecki dd15522
[FIX] Removed erroneous path from test case
Shrecki 6839d73
[autofix.ci] apply automated fixes
autofix-ci[bot] 379614e
[FEAT] Simplify label code and remove cruft code
Shrecki d3523b7
Merge branch 'pca_flip_volume' of github.com:Shrecki/mne-python into …
Shrecki 33f911d
[FIX] Removed trivial branch
Shrecki 256331b
Merge remote-tracking branch 'upstream/main'
Shrecki 1626e5f
Merge branch 'main' into pca_flip_volume
Shrecki ec82986
[FIX] label_sign_flip incorrectly handled hemispheres
Shrecki 0ca43cf
Imports moved up top
Shrecki ee4a174
Updating mri_name to save volumetric source
Shrecki 3ce6b38
Fix of PCA flip in volume: returned constant 0 as flips meaningless i…
Shrecki 7ae37e5
Fixed pca flip branch
Shrecki d9580da
Handling of flip being an int
Shrecki fd71779
Using numpy svd instead of scipy
Shrecki 69937d2
PCA flip for volumetric is now using randomized SVD to manage to run …
Shrecki 8888c13
Simplification of PCA flip
Shrecki 775ec80
Logging
Shrecki 0fd4be5
Found a trick to make everything much faster with only two svds
Shrecki 1a89099
Flip handling in _compute_pca_quantitites
Shrecki b02c14c
Feat: montage now supports .pos information file
Shrecki 8a96fec
Float convert in digitization
Shrecki 1074c1a
Convert dig points to numpy array
Shrecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add PCA-flip to pool sources in source reconstruction in :func:`mne.extract_label_time_course`, by :newcontrib:`Fabrice Guibert`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better / more modern check would be something like:
And incidentally I think eventually we could add support for segmented volume source spaces, as well as mixed source spaces (once surface + volume are fully supported, mixed isn't too bad after that). But probably not as part of this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably! To support this, the (clarified) code in label_sign_flip with the hemis dictionary might be recycled: