Combo of small performance changes #4314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid having to recompute them for each hook
github-actions
bot
added
Z-EndToEndBenchCI
thanhnguyen-aws
approved these changes
Aug 25, 2025
|
Hi @thanhnguyen-aws, thanks for the approval! Do you mind merging this too? I got removed from the github model-checking org and no longer can. |
feliperodri
approved these changes
Sep 8, 2025
auto-merge was automatically disabled
September 8, 2025 20:44
Pull Request is not mergeable
Merged
via the queue into
model-checking:main
with commit Sep 8, 2025
6cb0ef0
33 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pair of small performance changes. It used to be 4 (and thus would've been a real combo), but two involved caching so I've moved them under #4313 instead. These changes include:
GotocHooks'hook_appliesmethod as arguments, so that each hook doesn't have to recompute it on it's ownThese are both very small, but together with the other two changes now moved to #4313, made a ~6% decrease in the compile time of the standard library.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.