Git issue 040

[ckormanyos]

This PR is intended to repair missing C++11 ` functions.

It addresses #40.

In my naive analysis, simply the position of a preprocessor #if-#else-#endif was actually removing C++11 math functions from the header.

[ckormanyos]

Hi @salkinium and @chris-durand this fixes the fpclassify omission (and also a few other C++11 mathematical functions).

[ckormanyos]

When using the avr-gcc image in CI to build the examples, I had breifly activated 64-bit double and, indeed, that linker is broken. So I walked the example back to 32-bit double.

This might be related to #38, as there is/was definitely a problem that I simply swept under the rug here.

[salkinium]

Sure!

[ckormanyos]

Hi @salkinium and @jwakely based on the review comments, I have converted this into a draft PR until I/we straighten out the math declarations more clealry.

Cc: @chris-durand

[ckormanyos]

OK folks, the latest, greatest <cmath> and improved docs is ready to go now. I've handled all of the review comments from @jwakely (thank you for these). We have closed #42 and will fix <cmath> here in this one.

So @chris-durand and @salkinium in I believe this one is ready now.

[ckormanyos]

This PR fixes #40

[jwakely]

LGTM

[ckormanyos]

Hi @salkinium and @chris-durand.

I think this one is good to go. Also, I could probably take a more active role in the support of this thing. So if you'd like to have that discussion, I'm all ears.

There is a lot of value in this work. We could discuss the future evolution of this work any time.

Cc: @jwakely

[salkinium]

Also, I could probably take a more active role in the support of this thing.

That would be great! You've already polished this repo a lot, so I've upgraded you to write access, so you should be able to merge this PR now.

[ckormanyos]

I could probably take a more active role in the support of this

That would be great! You've already polished this repo a lot, so I've upgraded you to write access

Thanks Niklas (@salkinium) I'll do my best

Cc: @chris-durand