-
-
Notifications
You must be signed in to change notification settings - Fork 365
build(esbuild): migrate from rollup to rslib #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace Rollup with RSLib to simplify config and speed builds. - Switch Nx target to run rslib; add rslib.config.ts and @rslib/core - Remove rollup config and dependencies; update eslint ignore - Set tsconfig rootDir for esbuild - Improve runtime sourcemaps for debugging - Remove obsolete main.py and update lockfile
🦋 Changeset detectedLatest commit: 467614b The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@codex double check pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
core/packages/esbuild/package.json
Lines 5 to 7 in 040fae2
"main": "./dist/index.cjs.js", | |
"module": "./dist/index.esm.js", | |
"types": "./dist/index.d.ts", |
[P1] Align esbuild package exports with rslib output filenames
The new rslib build emits default filenames like dist/index.js
and dist/index.mjs
for the CJS/ESM bundles, but the package metadata still points at dist/index.cjs.js
and dist/index.esm.js
(and the sub‑exports reference plugin.cjs.js
, plugin.esm.js
, etc.). After this migration the referenced files will not be generated, so requiring or importing @module-federation/esbuild
or its subpaths will throw MODULE_NOT_FOUND
. Configure rslib’s output
to keep the old naming scheme or update these paths to the names rslib actually produces.
Reply with @codex fix comments
to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
@codex fix comments and also add a changeset |
Summary
Testing
|
@codex can we remove the sourcemap changes done to the runtime rollup config? |
Summary
Testing
|
Summary
Details
This modernizes the esbuild package build:
Impact
Testing
Notes
Lockfile changes include adding @rslib/core and removing Rollup deps for esbuild package only.