Skip to content

Conversation

Thegrep01
Copy link
Contributor

Description

Adds E2E test for metro examples

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Sep 10, 2025

⚠️ No Changeset found

Latest commit: 127fc10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 127fc10
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68c39045c30e6700081061d3
😎 Deploy Preview https://deploy-preview-4056--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zackarychapple
Copy link
Collaborator

@jbroma want to take a peek at this as our MF core team member

@jbroma
Copy link
Member

jbroma commented Sep 10, 2025

looks like the workflow is failing because of permissions

I think that since e2e-metro is getting called as a workflow-call and inheriting the token from the parent, parent must have all the necessary permissions already. It would be nice to check if we can limit the amounts of write permissions needed here tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants