-
-
Notifications
You must be signed in to change notification settings - Fork 365
refactor(enhanced): resolve alias-aware consumes in afterResolve with caching #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/share-resolver
Are you sure you want to change the base?
Conversation
… caching Move path equality checks to afterResolve for determinism. Cache target resolutions and track deps to reduce resolver churn.
Align tests with plugin tapping afterResolve to prevent undefined hook errors.
🦋 Changeset detectedLatest commit: 095f6aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review: Here are some suggestions. core/packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts Lines 470 to 493 in c701d85
[P1] Respect allowNodeModulesSuffixMatch when inferring prefix aliases The new Stage 3 alias logic always calls Reply with About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
Skip data: resources in afterResolve and createModule. Preserve virtual module handling by webpack. Broaden afterResolve candidates for deep-path shares. Example: next/dist/compiled/react alias. Avoid converting explicit relative or absolute requests into consumes. Preserves local nested resolution for deep sharing. Keep prefix and node_modules suffix matching as before. Add a changeset for @module-federation/enhanced.
Summary of fixes added in 095f6aa:
Validation:
Added a changeset for @module-federation/enhanced (patch). |
Summary
Tests
Notes