Skip to content

Conversation

@WooWan
Copy link
Contributor

@WooWan WooWan commented Nov 5, 2025

Description

Add support for Yarn package manager in TypeScript compilation for the DTS plugin.

Implementation:

  • Detects package manager via npm_config_user_agent environment variable
  • Returns appropriate executable command (yarn for Yarn, npx for npm/pnpm)
  • Falls back to npx when environment variable is unavailable

Rationale:

The npm_config_user_agent detection is reliable because DTS generation is always triggered through package manager scripts (yarn build, yarn dev, etc.), which automatically set this environment variable.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

I've categorized this as a feature, but if you think it's better classified as a bug fix, please let me know!

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 34cda5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@module-federation/dts-plugin Patch
@module-federation/cli Patch
@module-federation/enhanced Patch
@module-federation/manifest Patch
@module-federation/rspack Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/rspress-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
remote5 Patch
remote6 Patch
website-new Patch
@module-federation/runtime Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/runtime-core Patch
create-module-federation Patch
@module-federation/metro Patch
@module-federation/metro-plugin-rnef Patch
@module-federation/metro-plugin-rnc-cli Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 34cda5f
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/6911c09986d4890008fb1086
😎 Deploy Preview https://deploy-preview-4189--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@WooWan
Copy link
Contributor Author

WooWan commented Nov 10, 2025

@ScriptedAlchemy @2heal1 @danpeen Sorry for ping
Our team is actively using Yarn PNP, and if this pull request gets applied, it would be very helpful for adopting Module Federation 2.0. Could we possibly get a review?

@2heal1
Copy link
Member

2heal1 commented Nov 10, 2025

yes, thanks for contributing!

@WooWan
Copy link
Contributor Author

WooWan commented Nov 10, 2025

Thanks for the quick response! Much appreciated. 🙏
Happy to address any feedback or make improvements if needed.

@2heal1 2heal1 merged commit d729167 into module-federation:main Nov 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants