Newfeat

app/Console/Commands/LocationCreateOrUpdateCommand.php

@@ -6,12 +6,13 @@
 
 use App\Models\Country;
 use App\Models\State;
+use Exception;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Str;
 
-class LocationCreateOrUpdateCommand extends Command
+final class LocationCreateOrUpdateCommand extends Command
 {
     /**
      * The name and signature of the console command.
@@ -29,10 +30,8 @@ class LocationCreateOrUpdateCommand extends Command
 
     /**
      * Base API URL for the countries and states data.
-     *
-     * @var string
      */
-    protected $baseApiUrl = 'https://countriesnow.space/api/v0.1';
+    private string $baseApiUrl = 'https://countriesnow.space/api/v0.1';
 
     /**
      * Execute the console command.
@@ -57,29 +56,31 @@ public function handle(): void
             }
 
             DB::commit();
-        } catch (\Exception $e) {
+        } catch (Exception $exception) {
             DB::rollBack();
-            $this->error('Command failed: ' . $e->getMessage());
+            $this->error('Command failed: '.$exception->getMessage());
         }
     }
 
     /**
      * Get the countries data from the API.
+     *
+     * @return list<array<string, string>>
      */
-    private function getCountries(): array
+    private function getCountries()
     {
         try {
-            $response = Http::get("{$this->baseApiUrl}/countries/iso");
+            $response = Http::get($this->baseApiUrl.'/countries/iso');
 
             if ($response->successful()) {
                 return $response->json('data');
             }
 
-            $this->error('Failed to fetch countries data from API and the error is: ' . ($response->json('msg') ?? 'unknown error'));
+            $this->error('Failed to fetch countries data from API and the error is: '.($response->json('msg') ?? 'unknown error'));
 
             return [];
-        } catch (\Exception $e) {
-            $this->error('Error fetching countries: ' . $e->getMessage());
+        } catch (Exception $exception) {
+            $this->error('Error fetching countries: '.$exception->getMessage());
 
             return [];
         }
@@ -92,13 +93,11 @@ private function createOrUpdateCountries(array $countries): void
     {
         $this->info('Creating or updating country data...');
 
-        $countryData = array_map(function ($country) {
-            return [
-                'name' => Str::lower($country['name']),
-                'iso2' => $country['Iso2'],
-                'iso3' => $country['Iso3'],
-            ];
-        }, $countries);
+        $countryData = array_map(fn (array $country): array => [
+            'name' => Str::lower($country['name']),
+            'iso2' => $country['Iso2'],
+            'iso3' => $country['Iso3'],
+        ], $countries);
 
         Country::upsert(
             $countryData,
@@ -114,21 +113,23 @@ private function createOrUpdateCountries(array $countries): void
 
     /**
      * Get the states data from the API.
+     *
+     * @return list<array<string, string|list<array<string, string>>>>
      */
-    private function getStates(): array
+    private function getStates()
     {
         try {
-            $response = Http::get("{$this->baseApiUrl}/countries/states");
+            $response = Http::get($this->baseApiUrl.'/countries/states');
 
             if ($response->successful()) {
                 return $response->json('data');
             }
 
-            $this->error('Failed to fetch states data from API and the error is: ' . ($response->json('msg') ?? 'unknown error'));
+            $this->error('Failed to fetch states data from API and the error is: '.($response->json('msg') ?? 'unknown error'));
 
             return [];
-        } catch (\Exception $e) {
-            $this->error('Error fetching states: ' . $e->getMessage());
+        } catch (Exception $exception) {
+            $this->error('Error fetching states: '.$exception->getMessage());
 
             return [];
         }
@@ -152,13 +153,11 @@ private function createOrUpdateStates(array $states): void
                 continue;
             }
 
-            $stateData = array_map(function ($state) use ($countries, $countryIsoCode) {
-                return [
-                    'name' => Str::lower($state['name']),
-                    'code' => $state['state_code'],
-                    'country_id' => $countries[$countryIsoCode],
-                ];
-            }, $stateData);
+            $stateData = array_map(fn (array $state): array => [
+                'name' => Str::lower($state['name']),
+                'code' => $state['state_code'],
+                'country_id' => $countries[$countryIsoCode],
+            ], $stateData);
 
             State::upsert(
                 $stateData,

app/Console/Commands/MakeAdmin.php

@@ -7,7 +7,7 @@
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\Hash;
 
-class MakeAdmin extends Command
+final class MakeAdmin extends Command
 {
     /**
      * The name and signature of the console command.
@@ -26,7 +26,7 @@ class MakeAdmin extends Command
     /**
      * Execute the console command.
      */
-    public function handle()
+    public function handle(): void
     {
         $email = $this->option('email');
         $password = $this->option('password');

app/Helpers/GeneralHelper.php

@@ -10,7 +10,7 @@
      */
     function getVoterNumber()
     {
-        $voterNumber = 'VO' . str_pad((string) rand(0, 99999999), 8, '0', STR_PAD_LEFT);
+        $voterNumber = 'VO'.mb_str_pad((string) random_int(0, 99999999), 8, '0', STR_PAD_LEFT);
         $existingVoter = Voter::where('voter_number', $voterNumber)->first();
 
         if ($existingVoter) {

app/Http/Controllers/Api/LocationController.php

@@ -6,16 +6,12 @@
 
 use App\Http\Controllers\Controller;
 use App\Services\LocationService;
+use Exception;
 use Illuminate\Http\JsonResponse;
 
-class LocationController extends Controller
+final class LocationController extends Controller
 {
-    protected LocationService $locationService;
-
-    public function __construct(LocationService $locationService)
-    {
-        $this->locationService = $locationService;
-    }
+    public function __construct(private readonly LocationService $locationService) {}
 
     /**
      * Get all countries
@@ -34,7 +30,7 @@ public function statesByCountry(string $countryName): JsonResponse
     {
         try {
             $states = $this->locationService->getStatesByCountry($countryName);
-        } catch (\Exception $e) {
+        } catch (Exception) {
             return response()->json(['error' => 'Country not found'], 404);
         }
 

app/Http/Controllers/Auth/AuthenticatedSessionController.php

@@ -13,7 +13,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class AuthenticatedSessionController extends Controller
+final class AuthenticatedSessionController extends Controller
 {
     /**
      * Display the login view.

app/Http/Controllers/Auth/ConfirmablePasswordController.php

@@ -12,7 +12,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class ConfirmablePasswordController extends Controller
+final class ConfirmablePasswordController extends Controller
 {
     /**
      * Show the confirm password view.

app/Http/Controllers/Auth/EmailVerificationNotificationController.php

@@ -8,7 +8,7 @@
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 
-class EmailVerificationNotificationController extends Controller
+final class EmailVerificationNotificationController extends Controller
 {
     /**
      * Send a new email verification notification.

app/Http/Controllers/Auth/EmailVerificationPromptController.php

@@ -10,7 +10,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class EmailVerificationPromptController extends Controller
+final class EmailVerificationPromptController extends Controller
 {
     /**
      * Display the email verification prompt.

app/Http/Controllers/Auth/NewPasswordController.php

@@ -16,7 +16,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class NewPasswordController extends Controller
+final class NewPasswordController extends Controller
 {
     /**
      * Display the password reset view.
@@ -47,7 +47,7 @@ public function store(Request $request): RedirectResponse
         // database. Otherwise we will parse the error and return the response.
         $status = Password::reset(
             $request->only('email', 'password', 'password_confirmation', 'token'),
-            function ($user) use ($request) {
+            function ($user) use ($request): void {
                 $user->forceFill([
                     'password' => Hash::make($request->password),
                     'remember_token' => Str::random(60),
@@ -60,7 +60,7 @@ function ($user) use ($request) {
         // If the password was successfully reset, we will redirect the user back to
         // the application's home authenticated view. If there is an error we can
         // redirect them back to where they came from with their error message.
-        if ($status == Password::PASSWORD_RESET) {
+        if ($status === Password::PASSWORD_RESET) {
             return redirect()->route('login')->with('status', __($status));
         }
 

app/Http/Controllers/Auth/PasswordController.php

@@ -10,7 +10,7 @@
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Validation\Rules\Password;
 
-class PasswordController extends Controller
+final class PasswordController extends Controller
 {
     /**
      * Update the user's password.

app/Http/Controllers/Auth/PasswordResetLinkController.php

@@ -12,7 +12,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class PasswordResetLinkController extends Controller
+final class PasswordResetLinkController extends Controller
 {
     /**
      * Display the password reset link request view.
@@ -42,7 +42,7 @@ public function store(Request $request): RedirectResponse
             $request->only('email')
         );
 
-        if ($status == Password::RESET_LINK_SENT) {
+        if ($status === Password::RESET_LINK_SENT) {
             return back()->with('status', __($status));
         }
 

app/Http/Controllers/Auth/RegisteredUserController.php

@@ -15,7 +15,7 @@
 use Inertia\Inertia;
 use Inertia\Response;
 
-class RegisteredUserController extends Controller
+final class RegisteredUserController extends Controller
 {
     /**
      * Display the registration view.
@@ -34,7 +34,7 @@ public function store(Request $request): RedirectResponse
     {
         $request->validate([
             'name' => 'required|string|max:255',
-            'email' => 'required|string|lowercase|email|max:255|unique:' . User::class,
+            'email' => 'required|string|lowercase|email|max:255|unique:'.User::class,
             'password' => ['required', 'confirmed', Rules\Password::defaults()],
         ]);
 

app/Http/Controllers/Auth/VerifyEmailController.php

@@ -9,21 +9,21 @@
 use Illuminate\Foundation\Auth\EmailVerificationRequest;
 use Illuminate\Http\RedirectResponse;
 
-class VerifyEmailController extends Controller
+final class VerifyEmailController extends Controller
 {
     /**
      * Mark the authenticated user's email address as verified.
      */
     public function __invoke(EmailVerificationRequest $request): RedirectResponse
     {
         if ($request->user()->hasVerifiedEmail()) {
-            return redirect()->intended(route('dashboard', absolute: false) . '?verified=1');
+            return redirect()->intended(route('dashboard', absolute: false).'?verified=1');
         }
 
         if ($request->user()->markEmailAsVerified()) {
             event(new Verified($request->user()));
         }
 
-        return redirect()->intended(route('dashboard', absolute: false) . '?verified=1');
+        return redirect()->intended(route('dashboard', absolute: false).'?verified=1');
     }
 }

app/Http/Controllers/CandidateController.php

@@ -9,7 +9,7 @@
 use App\Models\Election;
 use Inertia\Inertia;
 
-class CandidateController extends Controller
+final class CandidateController extends Controller
 {
     /**
      * Display the specified candidate.

app/Http/Controllers/CandidateRequestController.php

@@ -12,7 +12,7 @@
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 
-class CandidateRequestController extends Controller
+final class CandidateRequestController extends Controller
 {
     /**
      * Show the form for creating a candidate request.
@@ -26,6 +26,7 @@ public function create(Election $election, Request $request)
             // Check if the user is an admin
             abort(403, 'Unauthorized action.');
         }
+
         if ($candidate && $candidate->user_id !== $user->id) {
             // Check if the user is authorized to create the request
             abort(403, 'Unauthorized action.');
@@ -60,6 +61,7 @@ public function store(Election $election, StoreCandidateRequest $request)
             // Check if the user is an admin
             abort(403, 'Unauthorized action.');
         }
+
         if ($candidate && $candidate->user_id !== $user->id) {
             // Check if the user is authorized to create the request
             abort(403, 'Unauthorized action.');

app/Http/Controllers/DashboardController.php

@@ -11,7 +11,7 @@
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 
-class DashboardController extends Controller
+final class DashboardController extends Controller
 {
     /**
      * Handle the incoming request.

app/Http/Controllers/ElectionController.php

@@ -13,7 +13,7 @@
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 
-class ElectionController extends Controller
+final class ElectionController extends Controller
 {
     /**
      * Display a listing of the election.
@@ -26,9 +26,10 @@ public function index(Request $request)
             $query->whereAny(
                 ['name', 'description'],
                 'like',
-                '%' . $request->search . '%'
+                '%'.$request->search.'%'
             );
         }
+
         $elections = $query->latest()->paginate(15)->onEachSide(1);
 
         return Inertia::render('Elections/Index', [
@@ -85,6 +86,7 @@ public function show(Election $election)
             $query->withCount('votes');
             $election->loadCount('votes');
         }
+
         // dd($election, $query->get());
         $candidates = $query->oldest()->paginate(15)->onEachSide(1);