Fix tostring() by joining with bytes instead of str #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvdkon thanks for the PR. guess that bug was due to the confusing docstrings/comments. They are from the python2 ages and talk about strings, but mean The AFAICS, emeraldtree does not have that support and only supports encoding to bytes. |
|
@dvdkon just curious, how did you find that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently a leftover from Python 2 to 3 migration,
tostring()joined the result oftostringlist()with an emptystrinstead of an emptybytes. This PR fixes the issue in a way that mirrors the standard library'sxml.etree.