Skip to content

Add debug message on job fail #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add debug message on job fail #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf532e
Add message on job failed to when running minion worker
pstray Oct 5, 2020
8b47fbf
Remove _dequeue, fix some spacing
pstray Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/Minion/Command/minion/worker.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,21 @@ sub run {

my $log = $self->app->log;
$log->info("Worker $$ started");
$worker->on(dequeue => sub { pop->once(spawn => \&_spawn) });
$worker->on(dequeue => sub {
$_[1]->once(failed => \&_failed);
$_[1]->once(spawn => \&_spawn);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use $_[1] over multiple lines.

});
$worker->run;
$log->info("Worker $$ stopped");
}

sub _failed {
my($job, $error) = @_;
my($id, $task) = ($job->id, $job->task);
$error =~ s/\n//;
$job->app->log->debug(qq{Job "$id", task "$task" failed: $error});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message format is rather inconsistent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to provide positive feedback on what a a consistent message should look like instead....

}

sub _spawn {
my ($job, $pid) = @_;
my ($id, $task) = ($job->id, $job->task);
Expand Down