INTPYTHON-653 & INTPYTHON-620 Make pandas optional and add free-threading support on Windows #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
changed the title
caseyclements
requested changes
Jun 20, 2025
| try: | ||
| from pandas.tests.extension import base | ||
| except ImportError: | ||
| pytest.skip("skipping pandas tests", allow_module_level=True) |
There was a problem hiding this comment.
Could you add some thing like "To include, create environment like so: uv sync --dev --extra test --extra test-polars --extra test-pandas"
There was a problem hiding this comment.
It's already part of just test, that seems redundant
There was a problem hiding this comment.
OK. As long as we are steering contributors to the justfile, that they've opened it, we're good.
| except ImportError: | ||
| self.skipTest("Test requires pandas") | ||
| arrow_schema = {k.__name__: v(True) for k, v in _TYPE_NORMALIZER_FACTORY.items()} | ||
| schema = {k: v.to_pandas_dtype() for k, v in arrow_schema.items()} |
There was a problem hiding this comment.
We use pandas to go from arrow to numpy?
There was a problem hiding this comment.
Just for this test, to get the right data types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #286.