Skip to content

INTPYTHON-419 Include the pyarrow status message in errors #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

INTPYTHON-419 Include the pyarrow status message in errors #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9752e1e
INTPYTHON-419 Include the pyarrow status message in errors
blink1073 Jul 1, 2025
a773263
Merge branch 'main' of github.com:mongodb-labs/mongo-arrow into INTPY…
blink1073 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bindings/python/pymongoarrow/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,12 @@ cdef class BuilderManager:
if count > builder.length():
status = builder.append_nulls_raw(count - builder.length())
if not status.ok():
raise ValueError("Failed to append nulls to", full_key.decode('utf8'))
raise ValueError("Failed to append nulls to", full_key.decode('utf8'), ":", status.message().decode('utf8'))

# Append the next value.
status = builder.append_raw(doc_iter, value_t)
if not status.ok():
raise ValueError("Could not append raw value to", full_key.decode('utf8'))
raise ValueError("Could not append raw value to", full_key.decode('utf8'), ":", status.message().decode('utf8'))

# Recurse into documents.
if value_t == BSON_TYPE_DOCUMENT and builder.type_marker == BSON_TYPE_DOCUMENT:
Expand Down Expand Up @@ -326,7 +326,7 @@ cdef class BuilderManager:
if builder.length() < count:
status = builder.append_nulls_raw(count - builder.length())
if not status.ok():
raise ValueError("Failed to append nulls to", field)
raise ValueError("Failed to append nulls to", field, ":", status.message().decode("utf8"))

return return_map

Expand Down Expand Up @@ -362,7 +362,7 @@ cdef class _ArrayBuilderBase:
value_t = bson_iter_type(&doc_iter)
status = self.append_raw(&doc_iter, value_t)
if not status.ok():
raise ValueError("Could not append raw value of type", value_t)
raise ValueError("Could not append raw value of type", value_t, ":", status.message().decode("utf8"))

cdef CStatus append_raw(self, bson_iter_t * doc_iter, bson_type_t value_t):
pass
Expand All @@ -376,7 +376,7 @@ cdef class _ArrayBuilderBase:
cpdef append_null(self):
cdef CStatus status = self.append_null_raw()
if not status.ok():
raise ValueError("Could not append null value")
raise ValueError("Could not append null value:", status.message().decode("utf8"))

cpdef void append_nulls(self, uint64_t count):
for _ in range(count):
Expand All @@ -402,7 +402,7 @@ cdef class _ArrayBuilderBase:
with nogil:
status = builder.get().Finish(&out)
if not status.ok():
raise ValueError("Failed to convert value to array")
raise ValueError("Failed to convert value to array:", status.message().decode("utf8"))
return pyarrow_wrap_array(out)


Expand Down
Loading