Skip to content

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 1, 2025

Description

Implement credential type hierarchy.

Note: Review of this PR might be easier looking at the new files instead of the differences.

  • Refactor provider and client codebase to reduce duplication and inconsistencies.
  • Rename token environment variable to MONGODB_ATLAS_ACCESS_TOKEN.

Link to any related issue(s): CLOUDP-345764

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli changed the title chore: Implement credential type hierarchy chore: Implement credential type hierarchy Oct 1, 2025
@lantoli lantoli force-pushed the CLOUDP-345764_credentials_hierarchy branch from 64e7977 to 2420ece Compare October 3, 2025 07:02
@lantoli lantoli force-pushed the CLOUDP-345764_credentials_hierarchy branch 2 times, most recently from 24a610e to eeb1d5f Compare October 3, 2025 11:17
…credentials_hierarchy

* CLOUDP-334161-service-accounts-dev:
  chore: Remove all attributes in assume_role except role_arn (#3745)
  chore: Fix SA dev branch merge (#3744)
  chore: Fix cleanup GHA after SA changes (#3742)
  chore: Fixes backport release issues (#3734)
  chore: Support generation of singleton resources with no delete operation (#3736)

# Conflicts:
#	internal/config/client.go
#	internal/config/transport_test.go
#	internal/provider/provider_sdk2.go
#	internal/service/organization/resource_organization.go
#	internal/service/organization/resource_organization_test.go
#	internal/testutil/acc/factory.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant