Skip to content

Conversation

AgustinBettati
Copy link
Member

Description

Very soon (CLOUDP-347910) this will be an autogenerated PR. Currently updating to latest changes so we dont block open PRs which are modifying generated resources (#3747, #3740)

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Comment on lines 531 to -451
Computed: true,
Optional: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in computability in analytics_specs.ebs_volume_type does not look correct, checked in API spec and it is present in the request schema. Will create a follow up ticket so we can look into more detail, we do already have some existing inconsistencies in the autogenerated cluster schema.

@AgustinBettati AgustinBettati marked this pull request as ready for review October 3, 2025 10:30
@AgustinBettati AgustinBettati requested a review from a team as a code owner October 3, 2025 10:30
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 10:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates autogenerated resource schemas to reflect the latest API changes for MongoDB Atlas clusters and stream instances. The changes prepare for an upcoming autogenerated PR process and ensure compatibility with existing open PRs.

  • Adds new computed fields for effective specs and internal cluster role in cluster API
  • Updates authentication configuration in stream instance API with method field and removes https_ca_pem
  • Adds max_tier_size configuration option for stream instances

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
internal/serviceapi/streaminstanceapi/resource_schema.go Updates authentication model by removing https_ca_pem field, adding method field, and introducing max_tier_size configuration
internal/serviceapi/clusterapi/resource_schema.go Adds internal_cluster_role field, new effective_* specs for analytics/electable/read-only nodes, and use_aws_time_based_snapshot_copy_for_fast_initial_sync flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AgustinBettati
Copy link
Member Author

merging to unblock other PRs

@AgustinBettati AgustinBettati merged commit ea8dfda into master Oct 3, 2025
51 checks passed
@AgustinBettati AgustinBettati deleted the update-generated-resources branch October 3, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants