Refactor FXIOS-13821 [CredentialProvider] Change CredentialProvider Display Name #29952
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This changes the
CFBundleDisplayNamevalue fromCredentialProviderto$(MOZ_BUNDLE_DISPLAY_NAME)which should fix the issue where password autofill in iOS 26 would show "CredntialProvider" instead of "Firefox" in the bottom sheet in Safari (for screenshots see #29947).I chose the
MOZ_BUNDLE_DISPLAY_NAMEvariable because it is already used in otherInfo.plistfiles forCFBundleDisplayName.firefox-ios/firefox-ios/Extensions/ShareTo/Info.plist
Lines 7 to 8 in a6f336d
Its value will be "Firefox" or similar, depending on the build configuration:
firefox-ios/firefox-ios/Client/Configuration/Firefox.xcconfig
Line 9 in a6f336d
📝 Checklist