Skip to content

Conversation

@FeBe95
Copy link

@FeBe95 FeBe95 commented Oct 9, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

This changes the CFBundleDisplayName value from CredentialProvider to $(MOZ_BUNDLE_DISPLAY_NAME) which should fix the issue where password autofill in iOS 26 would show "CredntialProvider" instead of "Firefox" in the bottom sheet in Safari (for screenshots see #29947).

I chose the MOZ_BUNDLE_DISPLAY_NAME variable because it is already used in other Info.plist files for CFBundleDisplayName.

<key>CFBundleDisplayName</key>
<string>$(MOZ_BUNDLE_DISPLAY_NAME)</string>

Its value will be "Firefox" or similar, depending on the build configuration:

MOZ_BUNDLE_DISPLAY_NAME = Firefox

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@FeBe95 FeBe95 requested a review from a team as a code owner October 9, 2025 19:17
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @FeBe95 sorry for the huge delay in the review. Thanks very much for addressing this !!

@mobiletest-ci-bot
Copy link

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 268e57c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants