Skip to content

Conversation

badboy
Copy link
Member

@badboy badboy commented Sep 8, 2025

It's as easy as that.
Just some small code changes to satisfy existing tests.

not sure if we actually test for the buckets in the payload anywhere, CI will tell me.

@badboy badboy requested a review from a team as a code owner September 8, 2025 15:50
@badboy badboy requested review from travis79 and removed request for a team September 8, 2025 15:50
@badboy badboy force-pushed the push-mvmylzpvutrs branch 2 times, most recently from b43c5fe to 6271791 Compare September 8, 2025 16:14
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with a CHANGELOG entry, please and thank you!

@badboy badboy requested a review from chutten September 10, 2025 09:48
@badboy
Copy link
Member Author

badboy commented Sep 10, 2025

@chutten (for when you return)

  1. Breaking in code yes/no?
  2. Does that need other work in the pipeline/GLAM and do we thus need to coordinate when releasing?

@badboy badboy marked this pull request as draft September 10, 2025 09:49
@chutten
Copy link
Contributor

chutten commented Sep 18, 2025

@chutten (for when you return)

1. Breaking in code yes/no?

It might be breaking because I believe we infill zeroes for test functions?

2. Does that need other work in the pipeline/GLAM and do we thus need to coordinate when releasing?

Nope. We're clear to land when we want to.

@badboy badboy marked this pull request as ready for review September 19, 2025 09:32
@badboy badboy merged commit 319e0d4 into main Sep 30, 2025
27 of 28 checks passed
@badboy badboy deleted the push-mvmylzpvutrs branch September 30, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants