Bug 1989902 - Rust: Use an associated type for TestGetValue to make it clear it's an output parameter #3259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
push-rwpnlmtyrnov
branch
2 times, most recently
from
bac9de2 to
03af169
Compare
…n output parameter Generic parameters are an "input". A trait `TestGetValue<T>` can be implemented for the same type multiple times with different concrete types `T`. That's never needed for `TestGetValue`, we only have a single type that should be returned from `test_get_value`. An associated parameter is the way to do that.
badboy
force-pushed
the
push-rwpnlmtyrnov
branch
from
03af169 to
39a0474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic parameters are an "input".
A trait
TestGetValue<T>can be implemented for the same type multiple times with different concrete typesT.That's never needed for
TestGetValue, we only have a single type that should be returned fromtest_get_value.An associated parameter is the way to do that.